search

pcwalton / rust-media

A free, comprehensive, and portable video/audio streaming library for Rust
Apache License 2.0
787 stars 57 forks source link

Fix race condition on fresh clone #34

Closed est31 closed 7 years ago

est31 commented 7 years ago

Previously, with a fresh clone you could get an error that mkvparse.hpp couldn't be found. This was because mkvparse.hpp is inside the libwebm-sys crate which is only used as dependency.

However, as cargo handles build.rs dependencies separately from the crate's dependencies, libwebm-sys sometimes wasn't copied/downloaded into the target/ directory yet when build.rs ran. By adding libwebm-sys to the build-dependencies of this crate we ensure its always inside target/.

Fixes #32 (together with commit 51dd086bfd95b7d76cfb4066619cbc613110fcc9)

est31 commented 7 years ago

I've added two commits to abandon all #![feature] tags on non mac platforms. On such platforms, we work on stable now! Maybe the dependency on the alloc crate for Mac could be somehow avoided as well, I'm not sure, but for that I'd need a mac to test it.