Closed voltaaage closed 7 years ago
@voltaaage is this ready to review?
If you have some advice, I'm open to any feedback you have. I'm planning to go through it and refactor things once I'm back from my weekend trip On Sat, Oct 8, 2016 at 6:17 PM Brian Herold notifications@github.com wrote:
@voltaaage https://github.com/voltaaage is this ready to review?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pcww/builder/pull/53#issuecomment-252457784, or mute the thread https://github.com/notifications/unsubscribe-auth/AGyCRVNAyo6vr9ZzGwIwBnThtTyICuvGks5qyECegaJpZM4KPmAC .
Ready for review :tennis:
@trezy @bmherold
Where do you see {calculated}? I'm pulling in the current width in the warning
Found the {calculated} piece: in BoardModel.json:
"length": "{calculated}",
export default class Wizard extends React.Component {
getDimensions () {
let board = this.props.board
return `${board.get('width')}" x ${board.get('length')}"`
}
This breaks because I removed the update length method. I'll have to throw it back in.
{calculated} issue fixed!!
{calculated}
is almost fixed. It still shows calculated when you first load up a board.@trezy I'm not disabling any controls at minimum width - just showing a warning like we discussed
The {calculated} issue is related to the length rendering. It seems to be coupled fairly tightly in the virtual board and I'm wondering if it's worthwhile to switch the logic over to use change how we're using width vs length - or just keep using length as is.
Current Issues:
Currently blocked by the #2 and #3 of the issues in the comment above. I think this PR relies on updating the API (flipping length and width in the response) & a clarification of the requirements in #3.
I added a temporary swap of length/width in the backbone model. This looks good. Once @trezy verifies as well we should merge this in and then make new tickets for anything outstanding.
Builds the feature for #30
Goals:
Considerations