search

pcww / builder

0 stars 0 forks source link

Implement a modal system #66

Closed trezy closed 7 years ago

trezy commented 7 years ago

We need a modal system that we can use to show off zoomed images, as well as a loading animations for the initial load and order submission.

voltaaage commented 7 years ago

Is this mostly for the images in the wizard?

What's wrong with the current loading animation?

brian-slate commented 7 years ago

We need "pop-ups" for various things. One of which is the wizard images, and probably something for notifications and such.

On Oct 28, 2016, at 1:55 AM, Fong Fan notifications@github.com wrote:

Is this mostly for the images in the wizard?

What's wrong with the current loading animation?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

voltaaage commented 7 years ago

@bmherold I probably should have clarified before going further down this path. I found a package that could be super useful called react-portal-tooltip but it's pretty similar to the tooltip package from react-bootstrap.

Then I realized that you wanted a modal system which could be pretty different from what I was envisioning, which was to show a larger version of the images in the wizard, right next to it. Are you referring to an actual modal with faded background?

trezy commented 7 years ago

@voltaaage It'd be helpful if it was a dialog that could be used as either a dialog (non UI blocking) or a modal (UI blocking).

voltaaage commented 7 years ago

So use both react-modal and react-portal-tooltip for the images in the wizard?

brian-slate commented 7 years ago

Main thing to start is to display images in a modal of each of the options in the wizard when clicking on the thumbnail.

On Nov 6, 2016, at 7:58 PM, Fong Fan notifications@github.com wrote:

So use both react-modal and react-portal-tooltip for the images in the wizard?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

trezy commented 7 years ago

It looks like react-modal is what we want.