Training scripts fail silently

pcyin / tranX

A general-purpose neural semantic parser for mapping natural language queries into machine executable code

Apache License 2.0

460 stars 111 forks source link

Training scripts fail silently #13

Closed neubig closed 4 years ago

neubig commented 4 years ago

When training scripts fail, it's hard to tell what happens because the output is written to a log file without any indication of where it goes. This has caused confusion for people: https://github.com/pcyin/tranX/issues/4

I think it'd be better to either:

Both pipe the output to log files, and display it on screen.
Provide an indication that output will be written to a log file. (or both).

I can send a PR for either of these pending https://github.com/pcyin/tranX/pull/12

neubig commented 4 years ago

Should be fixed by https://github.com/pcyin/tranX/pull/15