pd-l2ork / pd

L2Ork version of Pure-Data real-time digital signal processing language developed and maintained at DISIS, Virginia Tech
http://l2ork.music.vt.edu
127 stars 63 forks source link

Audio and Midi preferences windows are empty in Manjaro Linux. Complains about Xapian. #26

Closed rvega closed 9 years ago

rvega commented 9 years ago

Hi, I'm trying to use l2ork in Manjaro Linux. The same issue is present when I compile from git, when I compile using this PKGBUILD and when using binaries from here.

The Audio and MIDI preferences windows are empty and there are messages about it in the terminal output. Also, I installed the xapian tcl bindings before compiling but there are messages about not finding xapian as well.

Output log: https://gist.github.com/rvega/3e5780384e333bd1825c

agraef commented 9 years ago

Hi rvega, I already commented on this issue on https://aur.archlinux.org/packages/pd-l2ork/. It seems that, at least on Manjaro, the xapian-tcl-bindings package requires to have the tcllib package installed, too, because otherwise /usr/lib/tcllib isn't on Tcl's search path by default and so Tcl can't find the xapian package even though it is installed.

This also seems to fix the issue of the Audio and MIDI dialogs in the preferences coming up empty. Looking at pd.tk and your error log, it seems that if the package require xapian fails then Tcl bails out of pd.tk at line 8498 and consequently the dialogs (and a few other things) never get loaded.

So it seems that the xapian package is required by pd-l2ork now. I vaguely recall that it was optional at some point, but this doesn't seem to be the case any more. Maybe Ico can comment on this. The immediate fix for the Manjaro pd-l2ork package is to just make xapian-tcl-bindings a mandatory dependency and also make sure that tcllib gets pulled in, so that everything works smoothly.

Ico, in any case, I'd like to suggest that the call source [file join [file dirname [info script]] search-plugin.tcl] at pd.tk:8498 should be protected with a call to catch so that pd-l2ork handles the situation a little bit more gracefully if the xapian package isn't installed or can't be found. Even better would be if there was some code in search-plugin.tcl to detect the presence of the xapian package, and switch to the old-style help browser if it isn't found. Not sure how much work that is, though, and I'm afraid that I can't look into that myself right now. :(

jonwwilkes commented 9 years ago

You could also choose to bind the shortcut to the old browser when you catch that line in pd.tk -Jonathan

 On Wednesday, September 16, 2015 1:59 PM, Albert Graef <notifications@github.com> wrote:

Hi rvega, I already commented on this issue on https://aur.archlinux.org/packages/pd-l2ork/. It seems that, at least on Manjaro, the xapian-tcl-bindings package requires to have the tcllib package installed, too, because otherwise /usr/lib/tcllib isn't on Tcl's search path by default and so Tcl can't find the xapian package even though it is installed.This also seems to fix the issue of the Audio and MIDI dialogs in the preferences coming up empty. Looking at pd.tk and your error log, it seems that if the package require xapian fails then Tcl bails out of pd.tk at line 8498 and consequently the dialogs (and a few other things) never get loaded.So it seems that the xapian package is required by pd-l2ork now. I vaguely recall that it was optional at some point, but this doesn't seem to be the case any more. Maybe Ico can comment on this. The immediate fix for the Manjaro pd-l2ork package is to just make xapian-tcl-bindings a mandatory dependency and also make sure that tcllib gets pulled in, so that everything works smoothly.Ico, in any case, I'd like to suggest that the call source [file join [file dirname [info script]] search-plugin.tcl] at pd.tk:8498 should be protected with a call to catch so that pd-l2ork handles the situation a little bit more gracefully if the xapian package isn't installed or can't be found. Even better would be if there was some code in search-plugin.tcl to detect the presence of the xapian package, and switch to the old-style help browser if it isn't found. Not sure how much work that is, though, and I'm afraid that I can't look into that myself right now. :(— Reply to this email directly or view it on GitHub.

rvega commented 9 years ago

I can confirm that installing the tcllib package in Manjaro fixes the issue. Thanks! :)

pd-l2ork commented 8 years ago

Thank you all for the report. Given that xapian is the core of the new browser, I would argue it is required and therefore the catch is not necessary, particularly considering the old browser is now essentially unmaintained. Hope this helps!