search

pd-l2ork / pd

L2Ork version of Pure-Data real-time digital signal processing language developed and maintained at DISIS, Virginia Tech
http://l2ork.music.vt.edu
127 stars 63 forks source link

Arch fixes #51

Closed agraef closed 5 years ago

agraef commented 5 years ago

Some fixes to make pd-l2ork compile and run on Arch again. Fixes #50.

image

The larger IEM font sizes remain the same in relation to the base fonts no matter what dpi setting I choose. I suspect that there are some hardcoded font sizes there which just don't match up on modern systems any more. Any hints on how one might go about fixing these?

pd-l2ork commented 5 years ago

Thank you, Albert. Please check out the latest commits on the 1.x Branch where I ran into similar issues with the IEM objects and had to hard-code two different font sizes depending on the Ubuntu distro version by subtracting two (IIRC) from the actual font size that is being requested. I also deal with this in the build script which I know is not particularly graceful but it does the job for the time being.

Best,

Ico

-- Ivica Ico Bukvic, D.M.A. Director, Creativity + Innovation Institute for Creativity, Arts, and Technology

Virginia Tech Creative Technologies in Music School of Performing Arts – 0141 Blacksburg, VA 24061 (540) 231-6139 ico@vt.edu

www.icat.vt.edu www.performingarts.vt.edu l2ork.icat.vt.edu ico.bukvic.net

On Fri, Aug 9, 2019, 14:15 Albert Graef notifications@github.com wrote:

Some fixes to make pd-l2ork compile and run on Arch again.

-

Rev. 53f652b https://github.com/pd-l2ork/pd/commit/53f652b1a67454f58133a786dc9488106fb1438e points the wiringPi submodule to Jonathan's mirror at https://git.purrdata.net/jwilkes/wiringPi.git. It seems that git:// git.drogon.net/wiringPi is permanently offline, preventing the submodule from checking out.

Rev. e588077 https://github.com/pd-l2ork/pd/commit/e5880772446f2dc6b8817cd6be6e4ae215ff3e68 pulls over a fix from purr-data which makes OSCx compile on systems with newer (>= 2018) libc versions which don't have rpc/rpc.h any more; this change only adds an include path so that the module will compile if libtirpc is installed instead, and won't affect older systems.

Rev. b48b1fd https://github.com/pd-l2ork/pd/commit/b48b1fdf3bfea1dd4f4d792512e52dc3f82a0490 fixes a nonexistant ::pdwindow::post call that's supposed to report font scaling issues during startup. (I actually ran into these, see below.) Easily fixed by calling pdtk_post instead.

Rev. ecca59b https://github.com/pd-l2ork/pd/commit/ecca59b648cc5086fcd2165ae4cd499b7b4e0e68 makes an attempt to fix font scaling on high-dpi displays with dpi set to > 96 dpi. Specifically on my system with a font dpi setting of 120 I found that fit_font_into_metrics wouldn't be able to find suitable font sizes to match the prescribed font metrics. Simply increasing the maximum scaling factor there from 2 to 3 fixed the issue for me. The base fonts then look all right, although the IEM GUI font sizes are still way too large. Screenie:

[image: image] https://user-images.githubusercontent.com/2853977/62799660-afb82680-bae1-11e9-8182-634afbb9c984.png

The larger IEM font sizes remain the same in relation to the base fonts no matter what dpi setting I choose. I suspect that there are some hardcoded font sizes there which just don't match up on modern systems any more. Any hints on how one might go about fixing these?

You can view, comment on, or merge this pull request online at:

https://github.com/pd-l2ork/pd/pull/51 Commit Summary

  • Submodule wiringPi at git://git.drogon.net/wiringPi seems to be offline permanently, point to the mirror at https://git.purrdata.net/jwilkes/wiringPi.git instead.
  • Pull rev. cd51beba from purr-data.
  • Fix typo.
  • Fiddle with font scaling in order to cope with high-dpi diplay settings.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pd-l2ork/pd/pull/51?email_source=notifications&email_token=AAIEJVMHLWJ3XMWXVTHVGYLQDWX37A5CNFSM4IKWIYAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HEOTUQQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEJVPVQLQHJVRLVZKYIZTQDWX37ANCNFSM4IKWIYAA .

agraef commented 5 years ago

You mean rev. 11ae3d7b88a33e5d98f224018a3567ecb1d1f884? That looks like an awesome kludge indeed. If it works with current Ubuntu then it might just work with Arch as well. I'll give it a shot. ;-)

pd-l2ork commented 5 years ago

You are being rather generous by giving this a compliment by naming it a kludge ;-)

Best,

Ico

-- Ivica Ico Bukvic, D.M.A. Director, Creativity + Innovation Institute for Creativity, Arts, and Technology

Virginia Tech Creative Technologies in Music School of Performing Arts – 0141 Blacksburg, VA 24061 (540) 231-6139 ico@vt.edu

www.icat.vt.edu www.performingarts.vt.edu l2ork.icat.vt.edu ico.bukvic.net

On Fri, Aug 9, 2019, 14:57 Albert Graef notifications@github.com wrote:

You mean rev. 11ae3d7 https://github.com/pd-l2ork/pd/commit/11ae3d7b88a33e5d98f224018a3567ecb1d1f884? That looks like an awesome kludge indeed. If it works with current Ubuntu then it might just work with Arch as well. I'll give it a shot. ;-)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pd-l2ork/pd/pull/51?email_source=notifications&email_token=AAIEJVKGOQTFPKC7PMS66CDQDW423A5CNFSM4IKWIYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37QAWA#issuecomment-520028248, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEJVLOQAP34PMZOZW2MLTQDW423ANCNFSM4IKWIYAA .

agraef commented 5 years ago

Rev. eab3e978654b2d8cb0df5095f34481c09f56689d now adds the (aptly named) -k a.k.a. "kludge" option to force the awesome IEM font kludge on non-Ubuntu systems. ;-)

This actually does the trick! There, looks much better now:

image

So, if you have no objections, I'll merge this into master and update the Arch PKGBUILD, so that we can finally enjoy good ol' pd-l2ork 1 in Arch again! :)

agraef commented 5 years ago

One more thing. As I commented in rev. a339cf5a48146d946dc203cc5103a891331cd35d, the current HEAD of umlaeute's Gem has two somewhat serious issues, a faulty memory access during startup (which I found with valgrind) and a rather annoying regression in QT4L which causes Gem (and Pd) to completely lock up in video playback when at the end of the file (cf. https://github.com/umlaeute/Gem/issues/233). I've submitted pull requests for these at umlaeute's upstream repo (see https://github.com/umlaeute/Gem/pull/235 and https://github.com/umlaeute/Gem/pull/234) but he hasn't merged them yet.

I'd therefore like to suggest that, until IOhannes merges my PRs, we go with my branch at https://github.com/agraef/Gem/commits/gem-fixes instead. This has all the latest stuff from upstream + all of my own fixes. I already tested that with Purr Data, works great on both Arch and Ubuntu.

I'll add one last commit to this PR which updates Gem to my gem-fixes branch. I'll also take care of reverting that to upstream as soon as IOhannes has merged my PRs or fixes these bugs in some other way. Ok?

pd-l2ork commented 5 years ago

I think I fixed the startup with another kludge hack in the latest Gem branch that is applied by the build script. As for Qt, I would do the same until it is fixed usptream.

Best,

Ico

-- Ivica Ico Bukvic, D.M.A. Director, Creativity + Innovation Institute for Creativity, Arts, and Technology

Virginia Tech Creative Technologies in Music School of Performing Arts – 0141 Blacksburg, VA 24061 (540) 231-6139 ico@vt.edu

www.icat.vt.edu www.performingarts.vt.edu l2ork.icat.vt.edu ico.bukvic.net

On Fri, Aug 9, 2019, 16:28 Albert Graef notifications@github.com wrote:

One more thing. As I commented in rev. a339cf5 https://github.com/pd-l2ork/pd/commit/a339cf5a48146d946dc203cc5103a891331cd35d, the current HEAD of umlaeute's Gem has two somewhat serious issues, a faulty memory access during startup (which I found with valgrind) and a rather annoying regression in QT4L which causes Gem (and Pd) to completely lock up in video playback when at the end of the file (cf. umlaeute/Gem#233 https://github.com/umlaeute/Gem/issues/233). I've submitted pull requests for these at umlaeute's upstream repo (see umlaeute/Gem#235 https://github.com/umlaeute/Gem/pull/235 and umlaeute/Gem#234 https://github.com/umlaeute/Gem/pull/234) but he hasn't merged them yet.

I'd therefore like to suggest that, until IOhannes merges my PRs, we go with my branch at https://github.com/agraef/Gem/commits/gem-fixes instead. This has all the latest stuff from upstream + all of my own fixes. I already tested that with Purr Data, works great on both Arch and Ubuntu.

I'll add one last commit to this PR which updates Gem to my gem-fixes branch. I'll also take care of reverting that to upstream as soon as IOhannes has merged my PRs or fixes these bugs in some other way. Ok?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pd-l2ork/pd/pull/51?email_source=notifications&email_token=AAIEJVMTE4HTLVXNYXCVGNTQDXHO7A5CNFSM4IKWIYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37WEPY#issuecomment-520053311, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEJVKRU3W4V73ZA2BUZQ3QDXHO7ANCNFSM4IKWIYAA .

agraef commented 5 years ago

Ok, then I'll leave it up to you to add https://github.com/agraef/Gem/commit/53e3be2faf3d7d555ddae8f5d97e14449446b1b0 in a way that you see fit.

Ok to merge this PR then?

agraef commented 5 years ago

Just tested the same branch in Ubuntu 19.04, looks even better there:

ubuntu-screenie

So there might be some additional tweaks in order on Arch to make it look like that. But it's certainly usable there as well.

debuild works fine there, too, so at long last I can now provide pd-l2ork1 packages in my PPAs for current Ubuntu systems again. Nice :)

agraef commented 5 years ago

@pd-l2ork, ist it ok if I just go ahead and merge this? Or do you still need time to review?

agraef commented 5 years ago

I just realized that it's been more than 3 years that anyone else but me merged a pull request over here, so you might well have forgotten how to do it. ;-) So I'm just going ahead with this now. It's not a big changeset, so we can always roll it back later if needed. Just don't yell at me. :)

pd-l2ork commented 5 years ago

This is perfect. Thank you, Albert.

Best,

Ico

-- Ivica Ico Bukvic, D.M.A. Director, Creativity + Innovation Institute for Creativity, Arts, and Technology

Virginia Tech Creative Technologies in Music School of Performing Arts – 0141 Blacksburg, VA 24061 (540) 231-6139 ico@vt.edu

www.icat.vt.edu www.performingarts.vt.edu l2ork.icat.vt.edu ico.bukvic.net

On Sat, Aug 10, 2019, 10:18 Albert Graef notifications@github.com wrote:

Merged #51 https://github.com/pd-l2ork/pd/pull/51 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pd-l2ork/pd/pull/51?email_source=notifications&email_token=AAIEJVJP2BPCH5F3SV7XVN3QD3EZ5A5CNFSM4IKWIYAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS7REFZQ#event-2548187878, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEJVITHV3SGZM55O3YSP3QD3EZ5ANCNFSM4IKWIYAA .