search

pd-projects / fftease

live spectral sound processors for Pd
Other
28 stars 0 forks source link

Code needs a small update to work with Pd 0.52 #2

Open shakfu opened 2 years ago

shakfu commented 2 years ago

Pd 0.52 removed the error() function (unfortunately, without a deprecation notice), but it can easily be replaced with pd_error().

To fix the code in the repo you can run something like this in the project root:

rpl -R -x ".c" " error(" " pd_error(0, " .

patch.txt

A patch with the changes is attached.

umlaeute commented 2 years ago

pd_error() takes a handle to the object itself as a first argument, so the user can simply click on the error message to find the object that emitted the message.

so it's much preferred to provide an actual handle (e.g. pd_error(x, ...)) rather than just NULL.

@shakfu it might also be easier to just create a PR

umlaeute commented 2 years ago

oh, and actually you should direct the PR to https://github.com/ericlyon/pd-fftease which is where fftease is currently developed.