CI: integration test - Githubissues

pd-rs / crank

A wrapper for cargo to use creating games for the Playdate handheld gaming system.

MIT License

85 stars 15 forks source link

CI: integration test #10

Closed boozook closed 2 years ago

boozook commented 2 years ago

added rustfmt check
refactored cargo test job
added integration test

Integration tests with crankstart:

[x] macOS: OK
[ ] linux: CI is OK, Crank seems broken
[ ] windows: I don't know how to install SDK
- -

On linux SDK installed normally. Crank fails with that:

INFO  crank > make_source_dir
 INFO  crank > link_dylib
 DEBUG crank > copy: "/home/runner/work/crank-1/crank-1/crankstart/target/release/examples/libhello_world.dylib" -> "/home/runner/work/crank-1/crank-1/crankstart/target/Hello World/pdex.dylib"
Error: No such file or directory (os error 2)

rtsuk commented 2 years ago

It's weird that it's making a dylib on Linux. I confess I've not used the Linux support much, if at all.

boozook commented 2 years ago

This workflow is awaiting approval from a maintainer in https://github.com/rtsuk/crank/pull/10

boozook commented 2 years ago

There's no dylib, just so.

rtsuk commented 2 years ago

At https://github.com/rtsuk/crank/runs/5600125703?check_suite_focus=true#step:11:101 it is trying to copy a dylib, perhaps that needs to use the .so extension?

boozook commented 2 years ago

I'm not sure but seems to.

rtsuk commented 2 years ago

It appears that https://github.com/rtsuk/crank/blob/main/src/main.rs#L425 needs to be broken out into linux and macOS. I don't have a linux setup right now. I'd be fine with disabling Linux and adding an issue to fix it, which hopefully a linux user can take on.

boozook commented 2 years ago

Fixed. But currently I cannot test run in sim on linux. Actual questions:

Is there any way to validate resulting package .pdx?
- I'm not sure is there should be lib named as pdex.so or pdex.dylib in the package.

boozook commented 2 years ago

I'm played with it. See https://github.com/fzzr-/crank-1/pull/4/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR421-R424

boozook commented 2 years ago

I'd be fine with disabling Linux and adding an issue to fix it

Okay. I'll just comment the linux option in the job-matrix as same as windows already. Could you create issues please?

boozook commented 2 years ago

Also, again

This workflow is awaiting approval from a maintainer in https://github.com/rtsuk/crank/pull/10

boozook commented 2 years ago

Todo issues:

CI: fix SDK installation on windows
Crank: fix and test package build for linux
Crank: test package build for linux

boozook commented 2 years ago

I think this PR is ready.

linux & windows jobs are disabled for integration tests, but enabled for build and unit-tests
fixed rustfmt job, fixed code formatting (one line :) )
fixed dylib/so packaging for linux