Add new platform: Gitee

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter

Apache License 2.0

1.56k stars 134 forks source link

Add new platform: Gitee #118

Closed pd4d10 closed 3 years ago

pd4d10 commented 3 years ago

https://gitee.com/

shreyas1599 commented 3 years ago

Hi @pd4d10, I'm trying to add the issue screen. Need some help. IssueItem takes a required parameter called number but gitee issue numbers are not integers. They look something like this: #I2BRYV. Which of these would you suggest or is there an alternative apart from this?

Should I update IssueItem and make number as a String and update this across everything?
Should I use the id parameter of the response (this is an integer) for now?

pd4d10 commented 3 years ago

Well, it seems just used as a title.

Perhaps replace the int number prop with a String title?

shreyas1599 commented 3 years ago

title prop already exists. Do you mean remove the number prop and append the issue number to title?

pd4d10 commented 3 years ago

Oh, sorry, I missed that. It seems like a subtitle.

pd4d10 commented 3 years ago

append the issue number to title

It's a good idea, but I've noticed that the style is a little different with the title and wrapped with a TextSpan.

How about replacing it with String subtitle?

shreyas1599 commented 3 years ago

How about replacing it with String subtitle?

Alright I'll do this

pd4d10 commented 3 years ago

This issue could be closed since Gitee is already supported. Let's track the features and bugs of Gitee with new issues.

shreyas1599 commented 3 years ago

@pd4d10 going off-track here but can you enable Discussions on the repo(you're the admin)? It's for general discussions that may not necessarily be an issue. I opened it on my fork and it looks something like this:

pd4d10 commented 3 years ago

Enabled. I haven't used it before. Let's try it!