feat: gitee issues, issue, pullRequests screens

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter

Apache License 2.0

1.56k stars 134 forks source link

feat: gitee issues, issue, pullRequests screens #144

Closed shreyas1599 closed 3 years ago

shreyas1599 commented 3 years ago

Added Issues, PullRequests, Issue screens. PullRequest screen not done.
In Issues - creating an issue, commenting on an issue done
changed number prop to subtitle in issue_item.dart
Added a new prop prefix to comment_item.dart. CommentItem uses UserName which has the github prefix. Added a prefix prop so it works with sites other than github
In ge_pulls.dart, commentCount is set to 0 because the response from gitee doesn't have a comment count property. See this example response.
Screenshots:

shreyas1599 commented 3 years ago

Is the commenting on issue implementation fine? I just used the plus action button to open a new screen to type in the comment.

shreyas1599 commented 3 years ago

I'm also thinking of adding the edit comment and delete comment actions. Which one do you think is better?

1 - adding two different buttons side by side below the comment's text (or I could use text labels instead of icons) 2 - adding the three dot icon with menu options that have add/delete

Should I open a separate issue to discuss about this?

1 - looks something like this (I'll have to add the emoji also):

pd4d10 commented 3 years ago

adding the edit comment and delete comment actions

Great! Since there are enough changes in this PR, I think it's better to submit a new one to implement this.

1 - adding two different buttons side by side below the comment's text (or I could use text labels instead of icons) 2 - adding the three dot icon with menu options that have add/delete

Both would be fine. Considering the edit/delete is not very commonly used, maybe option 2 is better, in my opinion.

shreyas1599 commented 3 years ago

maybe option 2 is better

Alright. I think this is better too cause someone might click on the buttons accidentally. Also, we could add 'Quote reply` in the future and it would look very cluttered if there are more than 3 buttons(including the emoji) at the bottom.