search

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter
Apache License 2.0
1.53k stars 131 forks source link

Missing parts in github #174

Closed Thewisem closed 3 years ago

Thewisem commented 3 years ago

I would like for you to add releases which are available on github. Currently I don't see an option on gitlab that lets me check the releases of the software or app

pd4d10 commented 3 years ago

Thanks for your feedback!

Do you mean there should be a place in the app (maybe a button) to check if there is a new release?

shreyas1599 commented 3 years ago

I did something like this for now (does not display all assets. On click downloads the first downloadable asset. I'm thinking of adding all the assets). Releases tab is in the repo screen. I'm also thinking if we should create a separate directory for git touch downloads on the user's device(for now the download link opens in chrome and downloads to the device). This can also be useful if we implement a feature that allows file downloads

IMG_20210130_135747_777.jpg

Thewisem commented 3 years ago

Yes. Exactly what you said. A button for releases. :)

Thewisem commented 3 years ago

Try to show the changes they told they made in public in each release and each release itself. This way we can download directly from github. Sorry about the late response. Don't mind about the external download. The releases and publishes button should be there

Thewisem commented 3 years ago

It would help in not using my account on my browser and use my account on two gits soooo yeah. :).

pd4d10 commented 3 years ago

Actually, there is an entry for releases, which may be a little hidden:

It just directs to the web version. It would be more native with #179

simulator_screenshot_345850E6-5491-41F9-9CBB-B5B1650FED75

shreyas1599 commented 3 years ago

@pd4d10 I noticed the following a while back too. Recalled after seeing this image.

I had added icons for some of them but there's repetition in the use of icons and I used icons that don't exactly match the action. Are there any other icon packs? Or are there icons that come in a variety of filled colours(not just the different colour outlines, but the entire icon being filled). It would be good to use different colours in a single page. For example, one the repo page, it would be good to give a different colour for each of the tab

pd4d10 commented 3 years ago

The Octicons we are using is v1 (from flutter_vector_icon). It seems v2 is released for a while, which is landed in the GitHub web page

Perhaps we should upgrade to v2 too

shreyas1599 commented 3 years ago

The Octicons we are using is v1 (from flutter_vector_icon). It seems v2 is released for a while, which is landed in the GitHub web page

@pd4d10 You mean modifying this right? How did you get the icon data to create the file?

pd4d10 commented 3 years ago

You mean modifying this right

This package is supposed to be a port of react-native-vector-icons. Looks like the upstream package has no upgrade plan to octicons v2, so perhaps we should make it our own.

BTW, I just pushed a commit to main to replace most of the icons with ionicons. The best of it is that every icon has an outline version, which is really useful for indicating active/not active

How did you get the icon data to create the file

The react-native-vector-icons lib uses fontcustom to convert SVGs to icon font.

shreyas1599 commented 3 years ago

BTW, I just pushed a commit to main to replace most of the icons with ionicons.

Ah yes I noticed this in the screenshot you posted on the issue you opened a while ago. Looks better too imo.