feat(github): releases, gists(graphql)

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter

Apache License 2.0

1.53k stars 131 forks source link

feat(github): releases, gists(graphql) #179

Closed shreyas1599 closed 3 years ago

shreyas1599 commented 3 years ago

Gists (graphql)
Releases (download url is the first downloadable asset)
Graphql response does not return source code assets: in the below image only the apk asset is returned.
~Possible Improvement: If a release has multiple non-source code assets then use SimpleDialog, but there is no equivalent cupertino widget. Not sure if we should create a separate screen just for this?~
Screenshot

pd4d10 commented 3 years ago

Thanks!

I'm thinking if we should add more information to the releases page. This is the mobile web version:

simulator_screenshot_E9D7D45E-AABD-4814-9002-A630C9EC071F

shreyas1599 commented 3 years ago

I thought about this. There's a description prop for release but it does not seem to output what I thought it would (the "bug fixes" text in the image you included). It returns an empty string. Not sure if it's a bug or if it means something else. I've included all useful information exposed through the connection(except releasesCount. I'll add that). It's only there in 'REST`. Example url. Even the source code zip and tarball files are in here. Should we change it to rest or wait for github to expose these through graphql? I'll file an issue in github.community?

pd4d10 commented 3 years ago

change it to rest or wait for github to expose these through graphql

I think both would be fine. At least we could use the web version

file an issue in github.community

It's a good idea. But I'm not sure if it is in the official plan

shreyas1599 commented 3 years ago

There's a description prop for release but it does not seem to output what I thought it would (the "bug fixes" text in the image you included). It returns an empty string. Not sure if it's a bug or if it means something else.

Sorry my bad. the description returns a proper response. I was looking at earlier releases which had no descriptions. I ordered by descending order and the description works as expected.

shreyas1599 commented 3 years ago

Hi @pd4d10, I made a few changes. I thought it'd be better to list the assets and add a download button within the app itself instead of redirecting) Looks like this now:

Screenshot_1612089261

pd4d10 commented 3 years ago

The lint is fixed in the latest main branch. Could you do a rebase?