search

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter
Apache License 2.0
1.53k stars 130 forks source link

Inconsist strings #207

Closed linsui closed 3 years ago

linsui commented 3 years ago

In Settings/SYSTEM, GitHub status and Switch accounts are used instead of GitHub Status and Switch Accounts. Is that intended?

pd4d10 commented 3 years ago

Not quite sure. Is it a convention to capitalize the first letter of all words in English displays?

If yes, then it's better to correct it

linsui commented 3 years ago

I don't know, but I thought that those strings should be in the same format. Could you please choose a prefered format and correct inconsist ones?

shreyas1599 commented 3 years ago

I checked a few apps. They either follow all first letters capitalized or only the first letter of the string capitalized. In git touch some are only first letter capitalized while some are first letter of every word capitalised. Better to make it consistent. I'll make first letter of every word capitalised

luni-moon commented 3 years ago

Not quite sure. Is it a convention to capitalize the first letter of all words in English displays?

If yes, then it's better to correct it

Yes, if they are in a title, which this is, I assume, or a proper noun. Only one needs to be fulfilled, for this to be capitalized. I would say, capitalize every word in the strings (I am a citizen of The USA, and a primary English speaker, so I should know this).