search

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter
Apache License 2.0
1.56k stars 138 forks source link

[github] request review event type error #248

Closed pd4d10 closed 3 years ago

pd4d10 commented 3 years ago

simulator_screenshot_46A65892-BD9B-4D5C-9BEC-33494EF7C339

shreyas1599 commented 3 years ago

@pd4d10

It can be fixed by removing the typecasts in https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L445 and https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L456

Is there any specific reason why you've used typecasts? If typecasting is necessary then https://github.com/git-touch/git-touch/blob/ddfa9e469e5be888aef32b8b13fa09dac079f69c/lib/widgets/timeline_item.dart#L456 will have to be modified to GIssueData_repository_issueOrPullRequest__asPullRequest_timelineItems_nodes__asReviewRequestedEvent_requestedReviewer__asUser as the cast. I'll add a fix based on which you suggest is better

pd4d10 commented 3 years ago

Yeah, I guess it's just an issue of type. It should be enough to just correct the type (and make sure it doesn't break other places, of course)