search

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter
Apache License 2.0
1.56k stars 137 forks source link

added timeline item events #51

Closed shreyas1599 closed 4 years ago

shreyas1599 commented 4 years ago

Fixes #3

  1. CommitCommentThread
  2. PullRequestReviewThread
  3. PullRequestReviewComment

Apart from the above three, I've implemented everything else. I also updated the LockedEvent to use assignee instead of the now deprecated user.

I'm not exactly sure how to implement these. Aren't these already built by the final widget build? I could just modify the if statement of the final widget build to include the above three events. Would I be right in doing so?

pd4d10 commented 4 years ago

Thanks for the PR. Great work!

I'm not quite sure what these 3 types meant for. Perhaps we could leave these as is?

pd4d10 commented 4 years ago

This issue is added over a year. Time to close it!

shreyas1599 commented 4 years ago

Alright 👍