Make it work for desktop and web

pd4d10 commented 4 years ago

shreyas1599 commented 4 years ago

While at it, we could also fix inconsistencies on iPad.

shreyas1599 commented 4 years ago

Hi, @pd4d10

I added macos support. Looks very mobile-ish. Looks like we have to do a complete redesign. Will definitely take a lot of time. Something we could slowly do over time. I'm also not sure how to render specific designs for larger sizes. Does it happen through media-queries?
OAuth doesn't work. I updated the version of url_launcher to support launchUrl on macos. But seems like you have to tweak a setting in OAuth to support desktop? I'm not sure I've never used it before. Personal Tokens work as expected.
Web doesn't support dart:io. Probably why the app doesn't work on the web when I try to run it.
Also macos works only on the master channel of flutter.

Can I open a PR to add the required files for macos alone and updating the pubspec to use a newer version of url_launcher?

pd4d10 commented 4 years ago

Great!

I think we could make it work first, then make it better (such as design and user experience stuff)

Can I open a PR to add the required files

Sure. Just don't break current android and iOS builds

yusdacra commented 3 years ago

I believe https://github.com/go-flutter-desktop/hover can be very useful for this, since desktop builds + packaging is the reason it exists.

pd4d10 / git-touch