search

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter
Apache License 2.0
1.56k stars 137 forks source link

fix: transparent status bar #73

Closed shreyas1599 closed 4 years ago

shreyas1599 commented 4 years ago

Before:

image

After:

image

Looks better right? Also makes it more consistent with the look on iOS.

pd4d10 commented 4 years ago

It seems a native behavior of Android. I'm not sure, how do other apps handle it?

shreyas1599 commented 4 years ago

Some apps change the color and some others modify the app bar background to match the status bar hue. For example, Gmail, Facebook, PlayStore have the same color as the app bar,(they've changed default behavior) while Instagram and Whatsapp have retained the default behavior. The official Github app also has modified the status bar to match the app bar. So, if I'm right most apps which have a white background have changed the status bar color to make it white while the ones with more darker hues have retained the default behaviour. Or they've changed the tint of the app bar to make it seem more natural.

So it entirely depends on the app. But yeah, there are apps which change the default.

pd4d10 commented 4 years ago

OK, that's detailed enough. Just confirm the best practice because I'm not an expert of UI/UX

Is there any approach to move the action outside build method?

shreyas1599 commented 4 years ago

You're right. I should've placed it in main.dart. Is that fine?

pd4d10 commented 4 years ago

I think it is OK (If it works). So it would not be executed on every render.

shreyas1599 commented 4 years ago

It works. I checked.

nikolowry commented 3 years ago

Off-topic: why is the Android's variant widgets not properly themed? I "noped" right out when I saw the auth Actions sheet and then saw the tokens' dialog.