feat: files screen - Githubissues

pd4d10 / git-touch

An open-source app for GitHub, GitLab, Bitbucket, Gitea, and Gitee(码云), built with Flutter

Apache License 2.0

1.56k stars 137 forks source link

feat: files screen #75

Closed shreyas1599 closed 4 years ago

shreyas1599 commented 4 years ago

Fixes #74

I'm currently working on GistsScreen as well, so router.dart and github.dart includes portions for that(not completed yet). I should've done that on a separate branch :/. Should I add a commit to comment the gists portion out?
I'll open a pr asap for GistsScreen
I had to use the Card widget in files_item.dart as ExpansionTile required a parent that is a material widget. Container didn't work.

This is how it looks:

pd4d10 commented 4 years ago

Since this screen is only for viewing file changes, perhaps we could add a button to view in the browser? For someone who wants to get the full features of the GitHub web version, e.g. submit a review.

pd4d10 commented 4 years ago

Or use the share module to open the system share panel, which has open in the browser included.

shreyas1599 commented 4 years ago

Open in browser does not seem to appear in the share sheet. Should I use url_launcher instead?

( In the pull request screen you have used both 'Share' and 'Open in browser' options. Share uses the share module and open in browser uses launchUrl right?)

pd4d10 commented 4 years ago

https://github.com/git-touch/git-touch/blob/0063e99bbcfef81fbe0e0388289ceb40afeab40d/lib/screens/gh_repo.dart#L89-L105

The button in the repo screen could be for reference

shreyas1599 commented 4 years ago

Sorry, the first commit action url was incomplete