pd4d10 / octohint

The missing IntelliSense hint for GitHub and GitLab
https://chrome.google.com/webstore/detail/octohint/hbkpjkfdheainjkkebeoofkpgddnnbpk
MIT License
962 stars 35 forks source link

Hint view is clipped #11

Open aerze opened 6 years ago

aerze commented 6 years ago

First, awesome extension 🥇

I tested it by immediately browsing this same repo and the hint gets clipped by the code view.

You can reproduce by going to octohint/scripts/get-node-libs.js and hovering over fs.readFileSync

screen shot 2017-12-13 at 13 08 29

ideadapt commented 6 years ago

Fixable via position: absolute; on $background div. At least in chrome this works.

pd4d10 commented 6 years ago

@ideadapt Thanks. Actually it is absolute at first. We change it to relative to fix #10.

I think it is better to calculate the height, then decide to show it up or down, to make sure it is not clipped.