search

pd4d10 / octohint

The missing IntelliSense hint for GitHub and GitLab
https://chrome.google.com/webstore/detail/octohint/hbkpjkfdheainjkkebeoofkpgddnnbpk
MIT License
962 stars 35 forks source link

feature request: safari support #2

Closed notgiorgi closed 7 years ago

pd4d10 commented 7 years ago

Thanks for your recommendation.

IntelliOcto's code IntelliSense feature is powered by TypeScript language service. This bundle size is a little large(2M+ after uglify), so it may take some time to execute it for browsers.

For Chrome, this bundle will only execute once as background script when extension loaded. Content script only need to get position of mouse click or hover, communicate with background script, and render DOM.

I'm not sure if Safari extensions support background script like Chrome extension's. If not, this large bundle need to be executed every time on page loaded, it could be very slow.

I'll do some research on it. Also, pull request is very welcome.

pd4d10 commented 7 years ago

@notgiorgi v1.3.0 already has support Safari. Thanks for you suggestion! Guide here: https://github.com/pd4d10/intelli-octo#safari