Words not getting highlighted properly

pd4d10 / octohint

The missing IntelliSense hint for GitHub and GitLab

https://chrome.google.com/webstore/detail/octohint/hbkpjkfdheainjkkebeoofkpgddnnbpk

MIT License

962 stars 35 forks source link

Words not getting highlighted properly #23

Closed tanmayrajani closed 5 years ago

tanmayrajani commented 5 years ago

There seems to be a shift of one character when I tried to highlight a word today. Interesting thing is, it's not happening for every word in the file. I tried disabling every other extension and this still persists. Following is the screenshot of such occurance: (file in the image below)
Apart from that, when I tried it with refined-github enabled, I got the following behaviour. I think it's because of the feature: Tabs are shown as 4 spaces instead of 8 (I'm not able to find which file does that in RGH so I couldn't disable that feature and test)

pd4d10 commented 5 years ago

Thanks for your report.

Seems GitHub's first tab indent is 7, not 8. I don't know if it is a bug or by design. Already submit it to https://github.com/contact.
Currently GitHub determines tab size by checking project's .editorconfig. Octohint follows it. In this case, it seems more reasonable to determine tab size by page content already rendered, since other extensions or user scripts may change the default behavior

pd4d10 commented 5 years ago

@tanmayrajani Tab size is compatible with refined-github at v2.0.6, which is already published to Chrome Web Store. Should be auto updated soon.

The first issue is confirmed by GitHub Team. They are working on it.

tanmayrajani commented 5 years ago

Thank you for the quick implementation. Just verified the fix with Refined GitHub. I'll go ahead and close this issue now since the remaining part is from GitHub itself. Cheers! :)