pd4d10 / octohint

The missing IntelliSense hint for GitHub and GitLab
https://chrome.google.com/webstore/detail/octohint/hbkpjkfdheainjkkebeoofkpgddnnbpk
MIT License
962 stars 35 forks source link

Can not build for Firefox #24

Open linonetwo opened 5 years ago

linonetwo commented 5 years ago

I ran yarn && yarn start

But it stops at:

Child html-webpack-plugin for "options.html":
     1 asset
    Entrypoint undefined = options.html
    [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {0} [built]
    [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {0} [built]
        + 2 hidden modules

What's going on?

And if I download the crx from chrome store, install it to firefox resulted in There was an error during installation: File /Users/linonetwo/Downloads does not contain a valid manifest.

Can you provide a release for firefox officially?

pd4d10 commented 5 years ago

Try this one: firefox.zip

yarn start is used by dev, which is watching file changes and then recompile.

Can you provide a release for firefox officially?

It is submitted to AMO once but rejected by the reviewers. We can try again in the future. Let's keep this issue to track it.

Thanks for you suggestion! Ping me if some other thing gets wrong.

linonetwo commented 5 years ago

I tried it and it works Temporary.

Since I load it as a Temporary Extensions, so it disappears after I restart my firefox...

Hoping you pass review on firefox addon-store this time! There is no reason it is on Chrome store but not on firefox store.