search

pdclark / git-plugin-updates

Enable WordPress automatic updates for plugins hosted on Github or Bitbucket.
70 stars 9 forks source link

Enforcing header names? #26

Open afragen opened 11 years ago

afragen commented 11 years ago

Do we want to enforce the use of predefined headers, GitHub Plugin URI, BitBucket Plugin URI vs generic Git URI?

I think there can be unintended consequences for just parsing the Plugin URI, like those plugins hosted on both WP.org and GitHub? In a quick check I see that one of my .org plugins shows to update and the update wants to pull from GitHub.

I think we should parse based upon a predefined header.

pdclark commented 11 years ago

I'm fine with at least reducing it to an option that has to be turned on with a filter:

if ( apply_filters( 'ghu_parse_plugin_uris', false ) ) { /*...Look at those headers...*/ }

Or once there's an admin, those repos could be shown, but off by default.

Certainly agree that it should be turned off by default.

afragen commented 11 years ago

The problem with it being defaulted off is that any .org plugin with the header Plugin URI: https://github.com/… is going to try and be updated from GitHub and not from .org

pdclark commented 11 years ago

I may have not written clearly. I'm saying Git updates from Plugin URI off by default. The consequence being that any plugin with a Git address in Plugin URI would not be updated by Git. It would be updated by .org.

pdclark commented 11 years ago

PluginURI has been disabled for Git updates in https://github.com/brainstormmedia/git-plugin-updates/commit/20fb1ac2228b484b7b59f35e684a5c2410ce6cc7

pdclark commented 11 years ago

Is this now a duplicate of #20, or is there another component I'm missing?