pdedes / stack_store

0 stars 1 forks source link

Order Model: Order should Maintain Price @ Checkout even if Admin updates the price afterwards #34

Open pdedes opened 9 years ago

pdedes commented 9 years ago

The price of the product in the cart should not change once placed in the cart.

nogever commented 9 years ago

this applies to all, Cart, Wishlist and Order doesn't it?

pdedes commented 9 years ago

That's probably a good guess, Sean. This was the minimum requirement, so we can make it function as you described if you'd like.

Peter Dedes New York, NY

On 22 April 2015 at 12:05, SEAN notifications@github.com wrote:

this applies to all, Cart, Wishlist and Order doesn't it?

— Reply to this email directly or view it on GitHub https://github.com/pdedes/stack_store/issues/34#issuecomment-95249109.

nogever commented 9 years ago

So we need to embed prices to Cart, Wishlist, Order and let Angular use these prices instead of pulling from product.

Then, do we still need ref to obj? I think so.

and just made a commit with this change.

pdedes commented 9 years ago

I think we are accomplishing this today by saving a 'snapshot' of the price in the model, correct?

Peter Dedes New York, NY

On 22 April 2015 at 12:26, SEAN notifications@github.com wrote:

So we need to embed prices to Cart, Wishlist, Order and let Angular use these prices instead of pulling from product.

— Reply to this email directly or view it on GitHub https://github.com/pdedes/stack_store/issues/34#issuecomment-95255447.

lei-clearsky commented 9 years ago

So we will need a price field in Cart, Wishlist and Order model, right?