Merge ImageClipboard into Clipdata

pdeffebach / ClipData.jl

Move data to and from the clipboard in Julia

https://pdeffebach.github.io/ClipData.jl/stable/

MIT License

82 stars 6 forks source link

Merge ImageClipboard into Clipdata #17

Closed alecloudenback closed 3 years ago

alecloudenback commented 3 years ago

@pdeffebach - @hyrodium mentioned their new package ImageClipboard.jl with almost identical idea as this package, but for images. @hyrodium mentioned that they were amendable to bringing the functionality into this package for a unified source.

pdeffebach commented 3 years ago

I would maybe be okay with that. It doesn't have too many dependencies. But I would probably want the authors to make things work on mac OS.

I don't really understand why the implementation is so complicated, but I don't know anything about images and Julia.

hyrodium commented 3 years ago

Here's a link to the original conversation. (may be expired in few days because of slack's limitation) https://julialang.slack.com/archives/C6E4SU1D3/p1622879898104800

I don't really understand why the implementation is so complicated, but I don't know anything about images and Julia.

If there's an image in the system clipboard, clipboard() returns "" because the Base.clipboard method can handle only string data. This is why ImageClipboard uses system command such as xclip (in linux).

I think the easiest way to provide Clipdata.clipimage function is adding dependency to ImageClipboard, and I can make the PR when I finish adding support for mac OS and register ImageClipboard to General.

pdeffebach commented 3 years ago

I'm still not sure this is a good idea. I feel like no one would want to use both functionalities. The people who copy and paste from excel and the people who copy and paste images are non-intersecting sets.

Do you think there are people that would benefit from both being in the same package? As opposed to us coordinating an API and making sure the UX is similar across packages.

hyrodium commented 3 years ago

The people who copy and paste from excel and the people who copy and paste images are non-intersecting sets.

I agree with that.

At first, I thought the word "Data" in ClipData.jl means various types of data, including images. Pros and cons of implementing ClipData.clipimage are as follows.

pros

The meaning of the name of this package will be clarified, I guess.
Easy to find useful clipboard-related functions for beginner.

cons

It might go against our design philosophy.
Increasing dependency graph

Alternatively, more information on related packages in the documentations may be sufficient.

pdeffebach commented 3 years ago

Okay so I'm closing this.

We probably shouldn't have been so agressive with the name, calling it ClipTables.jl instead. Maybe we can consider renaming this package to avoid that confusion.

But ImageClipboard is doing fine and I don't think users need both functionalities at the same time.