search

pdeffebach / FloatingTableView.jl

Easy table viewing in a pop-up window in Julia
MIT License
43 stars 3 forks source link

table height? #12

Closed tbeason closed 3 years ago

tbeason commented 3 years ago

I'm having trouble changing table height. It seems the width is dynamic as I change the window, but I am always stuck with basically a fixed table height (which is very small relative to my available screen real estate). I see there is a height kwarg but I have not successfully used it yet.

pdeffebach commented 3 years ago

I just confirmed this on mac. I have no idea how to fix this, though, since this package is just a call to Blink.window. I'll see if I can figure something out.

jacobadenbaum commented 3 years ago

I just saw this package, and I immediately noticed this issue. You can fix it by calling showtable with the default argument showtable(df, height = "100vh"). See this issue in TableView. They can't change the default there since it would break the jupyter display, but since this package exclusively uses an electron window, it shouldn't cause any problems here. Happy to make a PR with this fix if it would be helpful! In the interim, you can change this behavior automatically since it looks like browse passes through arbitrary keyword arguments.

pdeffebach commented 3 years ago

Oh wonderful!

I will start a PR right away

jacobadenbaum commented 3 years ago

sorry! was 3/4 through the PR when you replied, so I figured I'd just finish it anyway