pdeljanov / Symphonia

Pure Rust multimedia format demuxing, tag reading, and audio decoding library
Mozilla Public License 2.0
2.42k stars 144 forks source link

Log flood #272

Open abique opened 8 months ago

abique commented 8 months ago

Hi, When turning on info, I get a huge amount of logs from symphonia:

[2024-03-16T11:04:01Z INFO  symphonia_core::probe] found the format marker [66, 4c, 61, 43] @ 0+2 bytes.
pdeljanov commented 8 months ago

You're probably probing many files at a time?

This will be quieter in version 0.6 (dev-0.6 branch), but I think the best practice here is for app developers to set a log filter when initializing your logger.

abique commented 8 months ago

Yes about a thousand files in a go. That's why this single line of log turn into flood :-)

abique commented 8 months ago

I think the best practice here is for app developers to set a log filter when initializing your logger.

This line of logs seems more like debug info or tracing, but it shouldn't show up when using the info log level in my opinion. I'm not super familiar with rust loggers, I went for env_logger and just set the global log level to info from the command line. Maybe yes there are better solutions.