search

pdemonaco / factorio-mod-updater

Python script to update mods on a dedicated factorio server
43 stars 14 forks source link

Remove use of auto and `with` for requests #20

Closed Munksgaard closed 3 years ago

Munksgaard commented 3 years ago

Fixes #19

This makes the script work in older versions of Python. I've tested with 3.4.2.

I haven't tested whether it still works with 3.7 or 3.6, so you should probably double-check that before merging.

clarfonthey commented 3 years ago

Considering how all versions before 3.6 are officially EOL, I don't think that this should be done, considering how it makes code quality worse and don't think that it's reasonable to hold future contributors to the standard of not using with statements. You mention in the other issue that your server has an old version of Python -- sounds to me like you need to update your server, instead of updating this script.

Munksgaard commented 3 years ago

That does sound reasonable indeed, thank you for considering though.

pdemonaco commented 3 years ago

@clarfonthey - totally agreed, thanks for reviewing. Apparently my email client decided Github notifications were spam so I'm just seeing this now.