search

pdemonaco / factorio-mod-updater

Python script to update mods on a dedicated factorio server
43 stars 14 forks source link

Formatting, player-data.json support, show deprecated mods #22

Closed clarfonthey closed 3 years ago

clarfonthey commented 3 years ago

Separated commits out so it's easier to follow. Basically:

  1. Reformatted using black since there were a few style inconsistencies and I figured using a standard tool was best.
  2. There were a few flake8 lints that I figured would be worth fixing
  3. I added support for player-data.json in addition to server-settings (priority is cli > server-settings > player-data)
  4. Deprecated mods add an extra message on validation success so they're easier to notice
pdemonaco commented 3 years ago

I like the idea of using a standard format/style. Can you add a CONTRIBUTING.md file which explains how to use black? and flake8 to validate contributions?

I'll have to read through more closely to make sure I understand the rest of the changes but they definitely sound good.

clarfonthey commented 3 years ago

Sorry I took a bit getting to this, but it's done. :)

Figured it'd be better to put in the readme since there isn't a whole lot to say in a contributing file, but can move to that if you prefer.