search

pdemonaco / factorio-mod-updater

Python script to update mods on a dedicated factorio server
42 stars 15 forks source link

Dependency Resolution Fails #25

Open undermark5 opened 1 year ago

undermark5 commented 1 year ago

Fails to download dependencies when the Factorio version of the mod is 1.1 and the factorio version installed is not. According to the Factorio wiki, if the mod's info.json only inludes major.minor it will be treated as compatible with all version matching major.minor.*. Many mods don't require a sub versioning requirement because the API has been stable for quite some time, so creating a mod today targeting 1.1 supports a large number of versions (not sure that many people still play on these older versions, but if they choose to, such mods should be compatible)

undermark5 commented 1 year ago

NVM, looks like it isn't the version matching that is the issue (well at least not in my case anyway). Something else is funky.

undermark5 commented 1 year ago

Ah, I found the issue, your regex for checking the dependencies doesn't work 100% of the time. For example, my mod pack of my QOL mods is nothing but dependencies, and I didn't specify the versions, the regex fails to match these therefore doesn't download them.