search

pderichs / sublime_rubocop

A Sublime Text RuboCop plugin.
238 stars 41 forks source link

Adding code highlighting #3

Closed petehamilton closed 10 years ago

petehamilton commented 11 years ago

It would be so awesome if running rubocop highlighted violations directly in the editor.

lenntt commented 11 years ago

:+1:

kakubei commented 10 years ago

+1 for this. As it is, it's kinda useless to me. I'd rather run it from the command line to actually see what's wrong, then run it once from within Sublime and then again if it reports anything. Especially since you can't choose to just run the linters from within Sublime.

pderichs commented 10 years ago

@kakubei I implemented this plugin to be able to

These are the main features of that plugin for now. If you don't need that, it is absolutely ok to use the "normal approach" (by which I mean switching between editor and terminal). I am not quite sure what you mean with "just run the linters from within Sublime" - can you explain that? EDIT: Now I see what you mean: I will open an issue for that feature - thanks for your hint!

@petehamilton (and others) Just to let you know: I definitely like the feature request really much and as soon as there is time, I will look into that ;-) . If you don't want to wait, I am happy for any assistance regarding that topic ;-)

BR pat

kakubei commented 10 years ago

Hi @pderichs. What I meant was that I usually run rubocop with just the -l option to find errors and not so much the style suggestions. It would be awesome to be able to see those error inside Sublime itself. Especially since SublimeLinter, which I used to use with ST2 no longer works for ST3 (even with the ST3 branch).

pderichs commented 10 years ago

Thanks for the hint! That is missing indeed, so I opened a new issue for that: Issue #8

pderichs commented 10 years ago

e7b7b0adaf8c61098a446459633d5fa419e30f81 extends the plugin to mark rubocop code remarks right in the editor. It needs some performance improvements in the future but it works quite well for now.

Just let me know, if you hit any issues.

BR pat