search

pderichs / sublime_rubocop

A Sublime Text RuboCop plugin.
238 stars 41 forks source link

Use current_project_folder when running rubocop #70

Open dan-corneanu opened 1 year ago

dan-corneanu commented 1 year ago

I've added a few lines of code to log the out and err strings from the rubocop process if the process exit code is something else than 0 or 1. This should give some clues about why some commands have no result.

I have also set the chdir options to the current_project_folder when running rubocop. This makes sure that if you have a per project .rubocop.yml it will be picked up.

pderichs commented 1 year ago

Thank you very much for your contribution @dan-corneanu! The changes are looking pretty good in general - I have added one minor comment but nothing severe.

Unfortunately I won't be able to test these changes in an appropriate way since 1.) I am no longer using Sublime Text and 2.) I am also no longer using all the required operating systems for testing.

Additionally due to a long term sickness this project's code lags a bit behind (... yes, this is an understatement).

So it makes sense to search for a new maintainer for this plugin.

@dan-corneanu Since you have opened this PR - would you possibly be interested to take over this repository as a maintainer?

I am currently not sure what the correct process looks like for a situation like this (and especially all the required steps for a Sublime Text plugin in particular), so this might take a bit of time to get things sorted.

(I assume it would just require a PR to https://github.com/wbond/package_control_channel as soon as a new maintainer is found)

zedtux commented 3 months ago

I have tested this PR locally, and it work like a charm, now the PWD environment variable is pointing to the current project folder instead of Sublime Text folder 👍.

Could be merged from my point of view. Thanks @dan-corneanu.

Also nice added debugs 🎉