search

pdet / Scrooge-McDuck

MIT License
129 stars 13 forks source link

make_uniq -> make_unique #14

Closed vbmithr closed 1 year ago

vbmithr commented 1 year ago

This fixes compilation!

pdet commented 1 year ago

Hi @vbmithr , make_uniq is necessary to make it work with the latest DuckDB versions (See https://github.com/duckdb/duckdb/pull/6950)

What version of DuckDB are you trying to compile scrooge with?

vbmithr commented 1 year ago

Hi @pdet. I just pulled your repo and hit make. So I don't know. Would be nice to have it working with the latest version (even better, included in DuckDB)

Edit: OK seems like I missed git submodule update.

vbmithr commented 1 year ago

Sorry, closing this.