search

pdevito3 / QueryKit

🎛️ QueryKit is a .NET library that makes it easier to query your data by providing a fluent and intuitive syntax for filtering and sorting.
Apache License 2.0
147 stars 13 forks source link

ParseFilter visibility #4

Closed vip32 closed 1 year ago

vip32 commented 1 year ago

Please make ParseFilter public instead of internal, so it can he used more broadly. PR?

pdevito3 commented 1 year ago

How else would you use it if it was exposed? Hesitant to expose it and confuse people, but if there's a good use case I'll consider it.

vip32 commented 1 year ago

To get to the expression outside of a dbcontext/dbset construct.

It lets the users of your lib use the functionality in a broader way by providing the expressions itself. That way they can also be used outside of EF.

I know you focus on EF, however this query > expression translation is very interesting in a broader context.

On Tue, Jun 20, 2023, 01:48 Paul DeVito @.***> wrote:

How else would you use it if it was exposed? Hesitant to expose it and confuse people, but if there's a good use case I'll consider it.

— Reply to this email directly, view it on GitHub https://github.com/pdevito3/QueryKit/issues/4#issuecomment-1597882188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIDTY6XWVFJA7EAEFG7VDXMDQNZANCNFSM6AAAAAAZMI7I7M . You are receiving this because you authored the thread.Message ID: @.***>

pdevito3 commented 1 year ago

Fair enough. Feel free to submit a PR or I'll try and get it in next release.

vip32 commented 1 year ago

please see #5 (minor change)

pdevito3 commented 1 year ago

FYI, i just published v0.4.0 which includes this