pdevito3 / craftsman

A .NET scaffolding tool to help you stop worrying about boilerplate and focus on your business logic 🚀
https://wrapt.dev
MIT License
1.12k stars 65 forks source link

Update Pulumi.Keycloak version, using image from keycloak.org docs #120

Closed Ken1Nil closed 1 month ago

Ken1Nil commented 1 year ago

docker-compose with admin settings, pulumi settings...

Was unable to run and configure KeycloakPulumi project with Oidc2 settings.

Updated docker-compose-yaml with keycloak image taken from https://www.keycloak.org/server/containers documentation. (No more emulation on AMD64, but the image sleighzy/keycloak:latest might still work for those that need ARM)

This version have KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD as environment variables input. They are reproduced in some of the Builders. (Maybe not all of them, what I could find).

When Pulumi.Keycloak runs, it uses the admin_cli from settings, and that one needs to match KEYCLOAK_ADMIN.

These changes needs some Documentation updates https://wrapt.dev/docs/auth-server-template#add-auth-server-template-properties

pdevito3 commented 1 year ago

👋 So for this works for you on a windows machine? Just gave it a whirl on my Mac and no joy. Ideally would like to find something that does both or otherwise figure out how to make either easily usable regardless of your box.

Ken1Nil commented 1 year ago

It does work on Windows machine.

The difference is only the image (ie: version of Keycloak inside image), running it on Windows still works with the sleighzy image but it's emulated from ARM to x64. When I changed to quay.io the install/configuration didn't work with Pulumi setup, therefor this PR is for the latest keycloak image version and quay.io source.

To solve i guess you could continue running the sleighzy/keycloak:latest. See if the KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD works? Or wait and hope sleighzy it gets the same version as official quay.io/keycloak/keycloak and merge these changes but ignore the docker-compose image: part...

Can close this since it doesn't work on ARM (newer Macs). Or see if my changes works with sleighzy/keycloak:latest since Pulumi stuff was newer.

pdevito3 commented 1 year ago

Yeah going to need think through options here 🤔 appreciate the heads up on this regardless