search

pdevito3 / craftsman

A .NET scaffolding tool to help you stop worrying about boilerplate and focus on your business logic 🚀
https://wrapt.dev
MIT License
1.12k stars 65 forks source link

Generated code contains both tabs and spaces #87

Open vde-developer opened 2 years ago

vde-developer commented 2 years ago

When using craftsman, generated classes contain a mix of tabs and spaces. Yes i know it doesn't matter functionally, and i don't have an opinion on tabs or spaces, just the mix of both can cause empty diffs in some diff software.

image

Craftsman version: 0.15.0

pdevito3 commented 2 years ago

Yeah there should be consistency here. Not sure when I'll get to this, but noted and I'll try to get to this.

If you want to submit a PR to fix them or at least some of the higher traffic classes, I'll accept it.

In the meantime, I'd recommend a dotnet format to fix them after a scaffold and before a commit.

vde-developer commented 2 years ago

Thanks about the dotnet format tip!

I've checked the behavior of generating classes with Craftsman after replacing all tabs with 4 spaces, and it seems to work as for me... But i honestly haven't had enough experience using it to know if I'm missing anything.

If anyone with more experience with Craftsman want to look I've created a pull request.

88