search

pdewacht / brlaser

Brother laser printer driver
GNU General Public License v2.0
576 stars 108 forks source link

Adding DCP7070-DW #166

Open loicdb75 opened 1 year ago

loicdb75 commented 1 year ago

I added an entry for the printer DCP7070-DW. Works fine

QORTEC commented 1 year ago

Thanks for submitting a pull request, interestingly pull request #107 for the DCP-7070DW was closed a month before your you opened yours.

I pushed an update to my pull request #92, in which I've merged support for the DCP-7070DW using the earlier pull request.

Taking a quick look, looks like the attributes from the earlier pull request and yours don't match. I don't know if this would effect anything, but I wouldn't expect it to.

Attribute "1284DeviceID" "" "MFG:Brother;CMD:PJL,PCL,PCLXL;MDL:DCP-7070DW;CLS:PRINTER;CID:Brother Laser Type1;"
Attribute "1284DeviceID" "" "MFG:Brother;CMD:PJL,HBP;      MDL:DCP-7070DW;CLS:PRINTER;CID:Brother Laser Type1;"
loicdb75 commented 1 year ago

As I mentionned, my entry works fine (raspbian on a raspberry cm4), but I think the #92 is a better one. After further verification, the DCP7070-DW is compatible PCL6 (PCLXL), and I didn't test HPB capability. the PR #92 seems to be more reliable than mine.

You can forget my quick and dirty fix, and thank you for maintaining your code !

QORTEC commented 1 year ago

Thanks, happy it's of use.