pdewacht / brlaser

Brother laser printer driver
GNU General Public License v2.0
592 stars 112 forks source link

Add Brother HL-2270DW, and standardize Brother naming #48

Closed QORTEC closed 5 years ago

QORTEC commented 5 years ago

Added Brother HL-2270DW to brlaser.drv.in:

{
  ModelName "HL-2270DW series"
  Attribute "NickName" "" "Brother HL-2270DW series, $USING"
  Attribute "1284DeviceID" "" "MFG:Brother;CMD:PJL,PCL,PCLXL;MDL:HL-2270DW series;CLS:PRINTER;CID:Brother Laser Type1;"
  Resolution k 1 0 0 0 "300dpi/300 DPI"
  Duplex rotated
  PCFileName "brl2270dw.ppd"
}

Standardized PCFileName in brlaser.drv.in:

Standardized Attribute in brlaser.drv.in: changed every instance of Brother <<MODEL>>, $USING to read Brother <<MODEL>> series, $USING I don't see why half the printers have the word "series" after the model, while the other half don't.

Added *~ to the .gitignore to prevent gedit tmp/backup files form being commited.

pdewacht commented 5 years ago

Thanks for the PR!

Unfortunately I can't accept the PCFileName changes. The spec says that once a filename has been chosen, it can't be changed anymore. And I'm pretty sure some software relies on that (For example, Debian's ppd-updater mechanism). Also, the file name can be at most 8 characters long. So your proposed names wouldn't work anyway.

For the printer names, I just copy the name used by the firmware, which, for these printers, seems to be generally sensible. The "series" term seems to be used when Brother releases multiple printers with the same electronics. For example, the HL-1200 and HL-1201 both identify themselves as "Brother HL-1200 series".

I've cherry-picked the other changes.