Closed QORTEC closed 5 years ago
Thanks for the PR!
Unfortunately I can't accept the PCFileName changes. The spec says that once a filename has been chosen, it can't be changed anymore. And I'm pretty sure some software relies on that (For example, Debian's ppd-updater mechanism). Also, the file name can be at most 8 characters long. So your proposed names wouldn't work anyway.
For the printer names, I just copy the name used by the firmware, which, for these printers, seems to be generally sensible. The "series" term seems to be used when Brother releases multiple printers with the same electronics. For example, the HL-1200 and HL-1201 both identify themselves as "Brother HL-1200 series".
I've cherry-picked the other changes.
Added Brother HL-2270DW to brlaser.drv.in:
Standardized
PCFileName
in brlaser.drv.in:brl2540.ppd
>>brl2540dw.ppd
brl2710.ppd
>>brl2710dw.ppd
All other printers have their feature suffix in the corresponding ppd file name.Standardized
Attribute
in brlaser.drv.in: changed every instance ofBrother <<MODEL>>, $USING
to readBrother <<MODEL>> series, $USING
I don't see why half the printers have the word "series" after the model, while the other half don't.Added
*~
to the .gitignore to prevent gedit tmp/backup files form being commited.