search

pdewit / nova-external-url

An external URL Laravel Nova field.
31 stars 6 forks source link

External Link text optional #2

Closed beliolfa closed 5 years ago

beliolfa commented 6 years ago

Hi, nice package! I was about to make this field but did a research before!

I am using this in a Spanish localized app but this External Link text is imposible to change.

Can you make it configurable and, even better, optional to display?

Nice work.

agustinprod commented 6 years ago

+1, also, it can be useful in case you want to add several links to a single resource.

niladam commented 5 years ago

@disitec @killgt - use the linkText function to change External Link, like so:

...

ExternalUrl::make('Slug', 'slug', function () {
    return url($this->slug);
    })->linkText($this->slug),

...

Obviously - you can pass anything to linkText.

niladam commented 5 years ago

Apparently this has been solved in #3 by @iaK 👍 :) -- didn't realise this wasn't available when @disitec opened the issue.

iaK commented 5 years ago

Close this maybe @pdewit?

pdewit commented 5 years ago

Yep, thanks.