pdfae / PDFAInspector

PDF Accessibility Inspector
8 stars 3 forks source link

Table Tab Feedback #25

Closed clblew closed 12 years ago

clblew commented 12 years ago

Like that you are showing the tables. This is great because if something is tagged as a table that should not be, then it is visually shown.

Thoughts:

When displaying the tables, can there be any indication other than bold/not bold (which is a little hard to distinguish) as to what the header cells are? When you go into the table editor in Acrobat, it puts little "TH" and "TD" labels on the cells. Is this able to be done? Just need some way to tell what the cells are. So, like the test document I did had 3 tables. On the report page it says 1 error in the "table must have headers" rule, but I have no way of knowing what table that is associated with.

Tables Must Contain Data Cells Of the three tables in my document, this rule shows that two violate this rule. All the tables contain data. What is this looking for?

Merged cells: Even when corrected in Acrobat to be noted as a merged cell correctly, the tables do not show with merged cells. Example: a 4 x 3 table. The 3rd and 4th cell in the top header row are merged. On the report output it shows the third cell with the text for that header and then the 4th cell is shaded in black instead of seeing the third cell extend across the 3rd and 4th column.

Table Summary: Is there a way to pull the table summary out? So maybe it could say "Table 1: Summary text here" or if there was no summary "Table 1: No table summary found"

schiele1 commented 12 years ago

From the Parsing and Rule Writing perspective:

The "Tables Must Contain Data Cells" rule looks for a TD tag inside any Table tag.

By "merged cell," do you mean cells with colspans or rowspans? Both col/row spans and summaries are read by the PDF parser; it seems we simply haven't implemented them in the table view yet.

clblew commented 12 years ago

Can send you the document to look at that I tested on this - each table does have TD elements in it.

schiele1 commented 12 years ago

Okay, I think I found the problem with the TD rule and I'm pretty sure I fixed it with this commit. https://github.com/klange/PDFAInspector/commit/3a8837382a9889ad37773051b58bb3e759795c9c