search

pdffillerjs / pdffiller

Take an existing PDF Form and data and PDF Filler will create a new PDF with all given fields populated.
MIT License
286 stars 113 forks source link

Tests Fail? #27

Closed deltreey closed 8 years ago

deltreey commented 8 years ago

I cloned the library and installed PDFtk for windows to try it out. It passed all tests but one (btw, you should probably list mocha as a dev dependency and update the package,json npm test script). The test was:

it('should generate another FDF Template with no errors', function(done){
    this.timeout(15000);
    pdfFiller.generateFDFTemplate( source1PDF, null, function(err, fdfTemplate) { 
        should.not.exist(err);
        fdfTemplate.should.not.eql(expected.test1.fdfTemplate);
        done();
    });
});

Notice the should.not.eql I'm confused. This test failed because the output matched the expected data. Maybe I'm missing something, but why shouldn't it?

whitef0x0 commented 8 years ago

Yep you are right the test should say should.eql

whitef0x0 commented 8 years ago

@johntayl can you close this?