search

pdffillerjs / pdffiller

Take an existing PDF Form and data and PDF Filler will create a new PDF with all given fields populated.
MIT License
289 stars 114 forks source link

Support PDF flattening as an option (re: Issue #31) #34

Closed kevitan closed 8 years ago

kevitan commented 8 years ago

as in Issue #31

fillForm() takes an extra boolean argument, specifying whether or not the resulting PDf should be read-only or remain still-fillable for the remaining fields.

whitef0x0 commented 8 years ago

You should add an example to the README as well

kevitan commented 8 years ago

done.

whitef0x0 commented 8 years ago

You should probably add a test case if possible.

kevitan commented 8 years ago

Is the preexisting one insufficient? It doesn't change the output in any testable way, does it?

Sent from my iPad

On Jun 5, 2016, at 00:07, David Baldwynn notifications@github.com wrote:

You should probably add a test case if possible.

― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

kevitan commented 8 years ago

I've added unit tests and separated out a version that has an option for flatten. the original one curries into the new version.

bluesockets commented 8 years ago

+1

whitef0x0 commented 8 years ago

@johntayl