Refactor GenFDFTempl and Clearer names for fdfs

pdffillerjs / pdffiller

Take an existing PDF Form and data and PDF Filler will create a new PDF with all given fields populated.

MIT License

286 stars 113 forks source link

Refactor GenFDFTempl and Clearer names for fdfs #37

Closed somombo closed 7 years ago

somombo commented 8 years ago

Refactor generateFDFTemplate to convert 'true/false' to 'yes/off'
Add "temporary" suffix to temporary fdf files to alert user that they can freely delete those files

whitef0x0 commented 8 years ago

@Makombo I'm not entirely sure if yes/off is clearer than true/false.

somombo commented 8 years ago

I don't believe this is all about clarity. Simply that Acrobat's default values for checked/unchecked boxes is "yes/Off". I presume this was precisely why the convFieldJson2FDF function converts true/false to "yes/Off".

While convFieldJson2FDF and generateFDFTemplate are not exactly identical, I hope we can agree that they equivalent in the sense that they are returning the exact same type of object (refer to test cases). So if one of those two functions (convFieldJson2FDF) is converting true/falseto "yes/Off" why isn't the other?

whitef0x0 commented 7 years ago

@somombo can you update your PR.

@johntayl can you have a look at this?

somombo commented 7 years ago

should be good now.. I still think the temporary files should still explicitly have at least "temp" as part of their name

somombo commented 7 years ago

thanks for incorporating the changes @johntayl

johntayl commented 7 years ago

No problem!