search

pdffillerjs / pdffiller

Take an existing PDF Form and data and PDF Filler will create a new PDF with all given fields populated.
MIT License
286 stars 113 forks source link

Modifications #53

Closed wmbutler closed 7 years ago

wmbutler commented 7 years ago

Here is the correct pull request. Sorry, I made some readme changes on my version that would have been wrong on yours.

whitef0x0 commented 7 years ago

@wmbutler I think it would be best to add this functionality as an opt-in option instead of having it on by default, to prevent breaking changes.

wmbutler commented 7 years ago

I saw your comment after this. So, maybe a flag called --keep?

whitef0x0 commented 7 years ago

@wmbutler might be better to add an options object when you require the library.

wmbutler commented 7 years ago

I'm not sure I follow.

whitef0x0 commented 7 years ago

See this https://github.com/mattdesl/module-best-practices#api-best-practices

whitef0x0 commented 7 years ago

@wmbutler I just added an option and added tests in this new PR https://github.com/johntayl/pdffiller/pull/54 based off your code.

wmbutler commented 7 years ago

Closing this in response to @whitef0x0 pull request.