Closed peteward closed 7 months ago
test and reviewing
Also, I'll fix main branch failing test. sorry
Very cool. this is a ideal sidebar position...! thank you.
but i fond bug, when i set multi page pdf template to form or viewer, PDF pages overflow the root element. I gonna investigate code changes.
also, when i set multi page pdf as besePdf to designer, we can see wrong position CtlBar.
you can reproduce from this template.json.
This behavior should be maintained.
https://github.com/pdfme/pdfme/assets/24843808/2f82e819-8d8e-40b6-86fe-c3a41fb383ad
So, we need check this pattern
↑ Pulled the main branch and incorporated fixes for tests and rotation. @peteward can you pull latest 248-sidebar-optimisation?
I'm looking into this now 👀
I think this is all working fine now - I have updated the PR description with information about the changes.
I didn't have any problem with the position of the CtrlBar though on the Designer, I'm not sure how you were seeing that 🤔
Single Page Designer:
https://github.com/pdfme/pdfme/assets/7068515/4ad5d637-221d-49db-916e-4fd309e4e641
Multi-page Designer:
https://github.com/pdfme/pdfme/assets/7068515/463c88e5-c304-41a3-bcc6-22a2571677e7
Hi @hand-dot,
Are these tests failing because it's taking a long time to run the generator integration tests?
I don't think I have made any changes here that would impact this... 🤔
Hi @hand-dot,
Are these tests failing because it's taking a long time to run the generator integration tests?
I don't think I have made any changes here that would impact this... 🤔
Sometime it occurs. Let's run again
Okay test is passing, I gonna check code tomorrow
implements #248
IMPROVEMENTS:
https://github.com/pdfme/pdfme/assets/7068515/d6479809-ec90-4bc2-82e6-51d71c4bb6b9
https://github.com/pdfme/pdfme/assets/7068515/8a4729a4-87da-49c2-9c07-488311ebb809