pdfme / pdfme

A TypeScript based PDF generator library, made with React.
https://pdfme.com
MIT License
2.19k stars 194 forks source link

Sidebar optimisation as separate panel instead of overlay #289

Closed peteward closed 7 months ago

peteward commented 7 months ago

implements #248

IMPROVEMENTS:

Screenshot 2023-10-26 at 13 26 31

Screenshot 2023-10-26 at 13 26 38

https://github.com/pdfme/pdfme/assets/7068515/d6479809-ec90-4bc2-82e6-51d71c4bb6b9

https://github.com/pdfme/pdfme/assets/7068515/8a4729a4-87da-49c2-9c07-488311ebb809

Screenshot 2023-10-26 at 13 19 01

hand-dot commented 7 months ago

test and reviewing

hand-dot commented 7 months ago

Also, I'll fix main branch failing test. sorry

hand-dot commented 7 months ago

Very cool. this is a ideal sidebar position...! thank you.

designer


but i fond bug, when i set multi page pdf template to form or viewer, PDF pages overflow the root element. I gonna investigate code changes.

CleanShot 2023-10-26 at 09 30 21

also, when i set multi page pdf as besePdf to designer, we can see wrong position CtlBar.

CleanShot 2023-10-26 at 09 40 41@2x

you can reproduce from this template.json.


This behavior should be maintained.

https://github.com/pdfme/pdfme/assets/24843808/2f82e819-8d8e-40b6-86fe-c3a41fb383ad

So, we need check this pattern

hand-dot commented 7 months ago

↑ Pulled the main branch and incorporated fixes for tests and rotation. @peteward can you pull latest 248-sidebar-optimisation?

peteward commented 7 months ago

I'm looking into this now 👀

peteward commented 7 months ago

I think this is all working fine now - I have updated the PR description with information about the changes.

I didn't have any problem with the position of the CtrlBar though on the Designer, I'm not sure how you were seeing that 🤔

Single Page Designer:

https://github.com/pdfme/pdfme/assets/7068515/4ad5d637-221d-49db-916e-4fd309e4e641

peteward commented 7 months ago

Single Page Viewer:

https://github.com/pdfme/pdfme/assets/7068515/4a8927e2-79db-4057-aa3a-4b4794989d92

peteward commented 7 months ago

Multi-page Designer:

https://github.com/pdfme/pdfme/assets/7068515/463c88e5-c304-41a3-bcc6-22a2571677e7

peteward commented 7 months ago

Multi-page Viewer:

https://github.com/pdfme/pdfme/assets/7068515/ae0f8243-83ab-4d0a-a516-7477f931eb7b

peteward commented 7 months ago

Hi @hand-dot,

Are these tests failing because it's taking a long time to run the generator integration tests?

I don't think I have made any changes here that would impact this... 🤔

hand-dot commented 7 months ago

Hi @hand-dot,

Are these tests failing because it's taking a long time to run the generator integration tests?

I don't think I have made any changes here that would impact this... 🤔

Sometime it occurs. Let's run again

hand-dot commented 7 months ago

Okay test is passing, I gonna check code tomorrow