Optimize (#911) - Githubissues

mitchelljkotler commented 1 year ago

Pull request

This closes #911, optimizing the apply_png_predictor, reducing the time from 29 minutes to 4 seconds on a particular PDF I have.

How Has This Been Tested?

I ran the test suite

Checklist

[x] I have read CONTRIBUTING.md.
[x] I have added a concise human-readable description of the change to CHANGELOG.md.
[x] I have tested that this fix is effective or that this feature works.
[x] I have added docstrings to newly created methods and classes.
[x] I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

pietermarsman commented 9 months ago

@mitchelljkotler Thanks for the update! There is still one test failing.

mitchelljkotler commented 9 months ago

@mitchelljkotler Thanks for the update! There is still one test failing.

I fixed the mypy check.. Now the docs are failing to build, but I believe that is unrelated?

pietermarsman commented 4 months ago

So merging.

pdfminer / pdfminer.six