pdidev / pdi

The PDI Data Interface
https://pdi.dev
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Vendor tars -> git submodule #158

Closed jbigot closed 3 months ago

jbigot commented 4 years ago

In GitLab by @ksiero on Dec 4, 2019, 10:28

There is a problem with mirroring repo to the github. The hdf5 tar file is over 100MB and github doesn't accept it. I think we could replace all tar in vendor with git submodules and pull them only if the user wants embedded (or auto set library to embedded). I think I was proposing this option before, but I don't remember why we didn't go with it.

jbigot commented 4 years ago

The reason is that we want our distribution to be easily installed on a machine with no internet access like many supercomputers.

The best solution would be to make a script to generate the distribution tar.gz executed in gitlab-ci and keep the tar out of the repo.

As a temporary workaround, we could just include a compressed version of HDF5 tar

jbigot commented 4 years ago

In GitLab by @ksiero on Dec 9, 2019, 14:19

There shouldn't be any problem with it. If the user wants to download all the plugins and libraries all he needs to do is add --recursive flag when cloning the repository and then copy it to the supercomputer, right?

jbigot commented 4 years ago

the question is about the tar we distribute for releases

jbigot commented 4 years ago

In GitLab by @ksiero on Dec 9, 2019, 14:22

There is no possible way to create a tar from the --recursive repository and then distribute it?

jbigot commented 4 years ago

yes, there is, this is what 'releases' https://docs.gitlab.com/ee/user/project/releases/ are for in gitlab. But we have to set it up.

I wouldn't use submodules however, just a tar as we do, but fetch it as part of the release creation process and use the public URL in git CMakelists.txt

jbigot commented 4 years ago

In GitLab by @ksiero on Dec 9, 2019, 14:33

Ok, there is no much gain when switching to submodules. There are more important jobs for now.

jbigot commented 4 years ago

In GitLab by @ksiero on Dec 9, 2019, 14:33

closed