pdidev / pdi

The PDI Data Interface
https://pdi.dev
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Add 'size_of' test for netcdf plugin #469

Closed Yushan-Wang closed 3 weeks ago

Yushan-Wang commented 1 month ago

Fix #446

Add support for size_of in decl_netcdf plugin Usage: only in read section

List of things to check before making a PR

Before merging your code, please check the following:

jbigot commented 4 weeks ago

Looks like when you apply indentation this messes up md files. Do you know why?

Yushan-Wang commented 4 weeks ago

Looks great. Could you add a separate issue on giving better error messages when the user specifies incompatible options in the config of the NetCDF of HDF5 plugins, e.g. both ".size_of" and ".when". Also could you add yet another one about proposing a better yaml syntax for the "size_of" case.

Currently, the when clause can work compatibly with size_of.

Yushan-Wang commented 4 weeks ago

Looks like when you apply indentation this messes up md files. Do you know why?

Yes, it was because when I was editing the changelog, my IDE automatically formatted the file. And I pushed without checking with the test_indent.

jbigot commented 3 weeks ago

Looks great. Could you add a separate issue on giving better error messages when the user specifies incompatible options in the config of the NetCDF of HDF5 plugins, e.g. both ".size_of" and ".when". Also could you add yet another one about proposing a better yaml syntax for the "size_of" case.

Currently, the when clause can work compatibly with size_of.

Ah, true! I missedit.