Closed Yushan-Wang closed 3 weeks ago
Looks like when you apply indentation this messes up md files. Do you know why?
Looks great. Could you add a separate issue on giving better error messages when the user specifies incompatible options in the config of the NetCDF of HDF5 plugins, e.g. both ".size_of" and ".when". Also could you add yet another one about proposing a better yaml syntax for the "size_of" case.
Currently, the when
clause can work compatibly with size_of
.
Looks like when you apply indentation this messes up md files. Do you know why?
Yes, it was because when I was editing the changelog, my IDE automatically formatted the file. And I pushed without checking with the test_indent.
Looks great. Could you add a separate issue on giving better error messages when the user specifies incompatible options in the config of the NetCDF of HDF5 plugins, e.g. both ".size_of" and ".when". Also could you add yet another one about proposing a better yaml syntax for the "size_of" case.
Currently, the
when
clause can work compatibly withsize_of
.
Ah, true! I missedit.
Fix #446
Add support for size_of in decl_netcdf plugin Usage: only in read section
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format
;Fix #issue
keyword to autoclose the issue when merged.