search

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!
https://discord.gg/brH5PGG8By
Other
227 stars 53 forks source link

Place Signs Contains Repeated Entries #162

Closed blockswerker closed 2 years ago

blockswerker commented 2 years ago

The "Place Signs" award contains repeated entries. I tried regenerating the place_sign.json and it didn't help. Here's an example: https://sweetanarchy.net/playerstats/index.html#award:place_sign

Edit: Is it possible that place_sign.py is including both 'minecraft:used' and 'minecraft:sign' to create it's list instead of just the sum?

pdinklag commented 2 years ago

The "Place Signs" award contains repeated entries. I tried regenerating the place_sign.json and it didn't help. Here's an example: https://sweetanarchy.net/playerstats/index.html#award:place_sign

This used to be #147 . Are you sure it wasn't fixed by the respective commit some 20 days ago?

Edit: Is it possible that place_sign.py is including both 'minecraft:used' and 'minecraft:sign' to create it's list instead of just the sum?

No, minecraft:sign is a subcategory of minecraft:used, you can think of the nested JSON objects as "paths" to the stats.

pdinklag commented 2 years ago

Yeah, looks like you didn't update yet. Updating MinecraftStats should fix this for you.