search

pdinklag / MinecraftStats

A Minecraft player statistics browser for the web - supports 1.13 and later!
https://discord.gg/brH5PGG8By
Other
228 stars 53 forks source link

Event summary page is displaying the wrong top score #198

Closed cunhar closed 1 year ago

cunhar commented 2 years ago

image https://www.hoobs.live/minecraft/#events image https://www.hoobs.live/minecraft/#event:spring_2022

It seems to be showing the total before the last update ran.

-- Ricardo

cunhar commented 2 years ago

image

it also seems to be different in the awards page.

pdinklag commented 2 years ago

I can confirm that this is always behind by one update and other bugs may occur as well because of some twisted logic.

Just to explain (and as a note to self) why there are so many issues with events: there are two conflicting "opinions" that MinecraftStats has internally of an event having started or ended. One is concerned about the times as defined in the config, the other about what data is available from previous updates. The reason is basically that updates may happen at any point, completely out of sync with the times defined in the config. The logic needs a serious overhaul, which I will look into.

This particular bug comes from #195, which fixed some issues, but really only added more faulty logic over already faulty logic. Fixing it is not trivial right now, but will be once the core problems are solved.

pdinklag commented 1 year ago

Events have been re-implemented in v3.0.0. This bug should be resolved, please reopen if not.